Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DENG-7656): add backfill.yaml to addons_derived.search_detection_v1 #6867

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kik-kik
Copy link
Contributor

@kik-kik kik-kik commented Jan 24, 2025

feat(DENG-7656): add backfill.yaml to addons_derived.search_detection_v1

Description

Adding the backfill entry to populate the new table with historical data.

depends on: #6869

┆Issue is synchronized with this Jira Task

@kik-kik kik-kik requested a review from wwyc January 24, 2025 15:25
@kik-kik kik-kik self-assigned this Jan 24, 2025
@dataops-ci-bot

This comment has been minimized.

@kik-kik kik-kik force-pushed the feat/DENG-7656/add-backfill-config-to-addons_search_detection_v1 branch from 61d8936 to e3fe48b Compare January 24, 2025 16:49
@dataops-ci-bot

This comment has been minimized.

@kik-kik kik-kik force-pushed the feat/DENG-7656/add-backfill-config-to-addons_search_detection_v1 branch from e3fe48b to e40c401 Compare January 24, 2025 21:14
@dataops-ci-bot
Copy link

Integration report for "feat: remove amo/prod workgroup for now"

sql.diff

Click to expand!
Only in /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/addons_derived/search_detection_v1: backfill.yaml
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/addons_derived/dataset_metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/addons_derived/dataset_metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/addons_derived/dataset_metadata.yaml	2025-01-24 21:17:19.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/addons_derived/dataset_metadata.yaml	2025-01-24 21:17:15.000000000 +0000
@@ -13,5 +13,6 @@
 - role: roles/bigquery.dataViewer
   members:
   - workgroup:mozilla-confidential
-  - workgroup:amo/prod
+  # Removed for now to allow compatibility with managed backfills.
+  # - workgroup:amo/prod
 syndication: {}
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/addons_derived/search_detection_v1/backfill.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/addons_derived/search_detection_v1/backfill.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/addons_derived/search_detection_v1/backfill.yaml	1970-01-01 00:00:00.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/addons_derived/search_detection_v1/backfill.yaml	2025-01-24 21:17:15.000000000 +0000
@@ -0,0 +1,8 @@
+2025-01-24:
+  start_date: 2021-08-06
+  end_date: 2025-01-24
+  reason: New table, backfill to populate it with historical data.
+  watchers:
+  - [email protected]
+  status: Initiate
+  shredder_mitigation: false
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/addons_derived/search_detection_v1/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/addons_derived/search_detection_v1/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/addons_derived/search_detection_v1/metadata.yaml	2025-01-24 21:20:04.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/addons_derived/search_detection_v1/metadata.yaml	2025-01-24 21:19:59.000000000 +0000
@@ -14,7 +14,6 @@
   incremental: true
   schedule: daily
   table_type: aggregate
-  shredder_mitigation: true
   dag: bqetl_amo_stats
   owner1: kik
 scheduling:

Link to full diff

@kik-kik kik-kik requested a review from alekhyamoz January 24, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants