Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove full names from data classes #3279

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Remove full names from data classes #3279

merged 6 commits into from
Aug 1, 2023

Conversation

codemist
Copy link
Collaborator

@codemist codemist commented Aug 1, 2023 •
edited
Loading

Fixes the issue with full-names becoming localized for being in the data-classes ftl file, as an issue with it being localized ahead of time pointed out in this conversation.

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@codemist codemist requested a review from flodolo as a code owner August 1, 2023 15:01
@codemist codemist merged commit 35745c0 into main Aug 1, 2023
@codemist codemist deleted the remove-full-names-from-data-classes branch August 1, 2023 19:33
mansaj added a commit that referenced this pull request Aug 2, 2023
@mansaj
Merge branch 'MNTOR-1937' of github.com:mozilla/blurts-server into MN…
b2e5a11 
…TOR-1937

* 'MNTOR-1937' of github.com:mozilla/blurts-server:
  MNTOR-1941: Fix tab integration (#3269)
  MNTOR-1859 - expose stats API, starting with scans (#3280)
  Remove full names from data classes (#3279)
  Add env var required for Next-Auth to work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flodolo flodolo flodolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codemist @flodolo