Skip to content

Commit

Permalink
Mention resolving perfalert as WONTFIX, and don't needinfo on bugs wi…
Browse files Browse the repository at this point in the history
…th backlog-deferred keyword (#2545)
  • Loading branch information
gmierz authored Nov 27, 2024
1 parent 95aede4 commit 661476d
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 13 deletions.
27 changes: 15 additions & 12 deletions bugbot/rules/perfalert_inactive_regression.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,20 @@ def get_bz_params(self, date):
# performance regressions
params = {
"include_fields": fields,
"f3": "creation_ts",
"o3": "greaterthan",
"v3": "2024-10-01T00:00:00Z",
"f1": "regressed_by",
"o1": "isnotempty",
"f2": "keywords",
"o2": "allwords",
"v2": ["regression", "perf-alert"],
"f9": "days_elapsed",
"o9": "greaterthan",
"v9": self.nweeks * 7,
"f1": "creation_ts",
"o1": "greaterthan",
"v1": "2024-10-01T00:00:00Z",
"f2": "regressed_by",
"o2": "isnotempty",
"f3": "keywords",
"o3": "allwords",
"v3": ["regression", "perf-alert"],
"f4": "keywords",
"o4": "nowords",
"v4": "backlog-deferred",
"f5": "days_elapsed",
"o5": "greaterthan",
"v5": self.nweeks * 7,
"status": ["UNCONFIRMED", "NEW", "REOPENED"],
"resolution": ["---"],
}
Expand Down Expand Up @@ -89,7 +92,7 @@ def filter_bugs(self, bugs):
# TODO: Attempt to needinfo the triage owner instead of ignoring the bugs
# Exclude bugs whose regressor author is nobody.
for bug in list(bugs.values()):
if utils.is_no_assignee(bug["regressor_author_email"]):
if utils.is_no_assignee(bug.get("regressor_author_email", "")):
logger.warning(
"Bug {}, regressor of bug {}, doesn't have an author".format(
bug["regressor_id"], bug["id"]
Expand Down
4 changes: 3 additions & 1 deletion templates/perfalert_inactive_regression_needinfo.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ It has been over {{ extra["nweeks"] * 7 }} days with no activity on this perform

:{{ nickname }}, since you are the author of the regressor, bug {{ extra[bugid]["regressor_id"] }}, which triggered this performance alert, could you please provide a progress update?

If you need additional information/help, please needinfo the performance sheriff who filed this alert (they can be found in comment #0), or reach out in [#perftest](https://matrix.to/#/#perftest:mozilla.org), or [#perfsheriffs](https://matrix.to/#/#perfsheriffs:mozilla.org) on Element.
If this regression is something that fixes a bug, changes the baseline of the regression metrics, or otherwise will not be fixed, please consider closing it as WONTFIX. [See this documentation for more information on how to handle regressions](https://firefox-source-docs.mozilla.org/testing/perfdocs/perftest-in-a-nutshell.html#help-i-have-a-regression-what-do-i-do).

For additional information/help, please needinfo the performance sheriff who filed this alert (they can be found in comment #0), or reach out in [#perftest](https://matrix.to/#/#perftest:mozilla.org), or [#perfsheriffs](https://matrix.to/#/#perfsheriffs:mozilla.org) on Element.

{{ documentation }}

0 comments on commit 661476d

Please sign in to comment.