ci: Run the sanitizers in parallel #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2166 +/- ##
==========================================
- Coverage 95.39% 95.38% -0.01%
==========================================
Files 112 112
Lines 36373 36373
==========================================
- Hits 34697 34696 -1
- Misses 1676 1677 +1 ☔ View full report in Codecov by Sentry. |
mxinden
approved these changes
Oct 10, 2024
Co-authored-by: Max Inden <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
|
Yes, I like a separate workflow better. |
|
@mxinden any ideas on what's causing the two failures? |
Benchmark resultsPerformance differences relative to 5f8d876. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.801 ns 99.064 ns 99.330 ns]
change: [-0.4137% +0.1527% +0.6230%] (p = 0.59 > 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [116.82 ns 117.17 ns 117.55 ns]
change: [+0.0552% +0.5266% +1.0686%] (p = 0.03 < 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.50 ns 116.95 ns 117.50 ns]
change: [+0.0359% +0.8467% +2.0023%] (p = 0.07 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [98.017 ns 98.163 ns 98.342 ns]
change: [-0.7539% +0.1719% +1.2076%] (p = 0.74 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.17 ms 111.22 ms 111.27 ms]
change: [-0.8529% -0.7912% -0.7246%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.927 ms 28.140 ms 29.392 ms]
change: [-3.6506% +1.9873% +7.9025%] (p = 0.49 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [35.284 ms 36.997 ms 38.729 ms]
change: [-2.8743% +4.3193% +11.825%] (p = 0.24 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [25.354 ms 26.170 ms 26.996 ms]
change: [-5.4377% -1.5867% +2.6055%] (p = 0.45 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [39.681 ms 41.495 ms 43.314 ms]
change: [-7.4968% -1.3183% +4.6377%] (p = 0.67 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [113.78 ms 114.30 ms 114.77 ms]
thrpt: [871.33 MiB/s 874.93 MiB/s 878.87 MiB/s]
change:
time: [-0.2018% +0.3948% +0.9476%] (p = 0.18 > 0.05)
thrpt: [-0.9387% -0.3932% +0.2022%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [314.42 ms 318.32 ms 322.19 ms]
thrpt: [31.038 Kelem/s 31.415 Kelem/s 31.804 Kelem/s]
change:
time: [-0.9214% +0.7517% +2.3260%] (p = 0.38 > 0.05)
thrpt: [-2.2731% -0.7461% +0.9300%]
1-conn/1-1b-resp (aka. HPS)/client: Change within noise threshold. time: [33.971 ms 34.124 ms 34.290 ms]
thrpt: [29.163 elem/s 29.305 elem/s 29.437 elem/s]
change:
time: [+0.2410% +0.9596% +1.7039%] (p = 0.01 < 0.05)
thrpt: [-1.6754% -0.9505% -0.2404%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
mxinden
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up the matrix.
Also grab MSRV from
Cargo.tomlinstead of hardcoding it.