Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump lukemathwalker/cargo-chef from ad035e2 to 49338f8 in /qns #2215

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 4, 2024

Bumps lukemathwalker/cargo-chef from ad035e2 to 49338f8.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps lukemathwalker/cargo-chef from `ad035e2` to `49338f8`.

---
updated-dependencies:
- dependency-name: lukemathwalker/cargo-chef
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from KershawChang as a code owner November 4, 2024 08:49
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 4, 2024
@dependabot dependabot bot requested a review from martinthomson as a code owner November 4, 2024 08:49
@dependabot dependabot bot added the docker Pull requests that update Docker code label Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Copy link

github-actions bot commented Nov 4, 2024

Benchmark results

Performance differences relative to 42fa260.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [99.681 ns 100.49 ns 101.74 ns]
       change: [+0.0297% +0.6462% +1.5748%] (p = 0.08 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
5 (5.00%) high mild
6 (6.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [117.26 ns 117.56 ns 117.89 ns]
       change: [-0.2077% +0.1605% +0.5034%] (p = 0.38 > 0.05)

Found 15 outliers among 100 measurements (15.00%)
2 (2.00%) low mild
2 (2.00%) high mild
11 (11.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [116.85 ns 117.26 ns 117.77 ns]
       change: [-0.4985% +0.0540% +0.6093%] (p = 0.85 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
3 (3.00%) low severe
1 (1.00%) low mild
7 (7.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.364 ns 97.507 ns 97.668 ns]
       change: [-0.8367% -0.0416% +0.6635%] (p = 0.92 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
5 (5.00%) high mild
6 (6.00%) high severe

RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [111.79 ms 111.85 ms 111.91 ms]
       change: [-0.0726% -0.0032% +0.0691%] (p = 0.93 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
6 (6.00%) low mild
3 (3.00%) high mild

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [27.196 ms 28.336 ms 29.497 ms]
       change: [-6.2642% -0.8529% +4.5339%] (p = 0.76 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [32.746 ms 34.549 ms 36.368 ms]
       change: [-9.7215% -3.4732% +3.6874%] (p = 0.32 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

transfer/pacing-false/same-seed: No change in performance detected.
       time:   [26.108 ms 26.830 ms 27.562 ms]
       change: [-5.0081% -0.8510% +3.4589%] (p = 0.69 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-true/same-seed: No change in performance detected.
       time:   [42.476 ms 44.493 ms 46.549 ms]
       change: [-4.0397% +2.5081% +9.1829%] (p = 0.46 > 0.05)
1-conn/1-100mb-resp/mtu-1500 (aka. Download)/client: No change in performance detected.
       time:   [902.53 ms 911.23 ms 920.01 ms]
       thrpt:  [108.69 MiB/s 109.74 MiB/s 110.80 MiB/s]
change:
       time:   [-2.2094% -0.8926% +0.4406%] (p = 0.18 > 0.05)
       thrpt:  [-0.4387% +0.9007% +2.2593%]
1-conn/10_000-parallel-1b-resp/mtu-1500 (aka. RPS)/client: No change in performance detected.
       time:   [317.83 ms 320.97 ms 324.20 ms]
       thrpt:  [30.845 Kelem/s 31.156 Kelem/s 31.463 Kelem/s]
change:
       time:   [-1.3239% +0.0168% +1.4647%] (p = 0.98 > 0.05)
       thrpt:  [-1.4435% -0.0168% +1.3416%]
1-conn/1-1b-resp/mtu-1500 (aka. HPS)/client: No change in performance detected.
       time:   [33.380 ms 33.558 ms 33.745 ms]
       thrpt:  [29.634  elem/s 29.799  elem/s 29.958  elem/s]
change:
       time:   [-0.8125% -0.1017% +0.5469%] (p = 0.78 > 0.05)
       thrpt:  [-0.5439% +0.1018% +0.8192%]

Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

1-conn/1-100mb-resp/mtu-1500 (aka. Upload)/client: No change in performance detected.
       time:   [1.6997 s 1.7191 s 1.7388 s]
       thrpt:  [57.512 MiB/s 58.171 MiB/s 58.834 MiB/s]
change:
       time:   [+0.0530% +1.6512% +3.3378%] (p = 0.06 > 0.05)
       thrpt:  [-3.2300% -1.6244% -0.0530%]

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

1-conn/1-100mb-resp/mtu-65536 (aka. Download)/client: Change within noise threshold.
       time:   [112.78 ms 113.00 ms 113.23 ms]
       thrpt:  [883.18 MiB/s 884.94 MiB/s 886.69 MiB/s]
change:
       time:   [-0.8470% -0.5536% -0.2663%] (p = 0.00 < 0.05)
       thrpt:  [+0.2670% +0.5567% +0.8542%]
1-conn/10_000-parallel-1b-resp/mtu-65536 (aka. RPS)/client: No change in performance detected.
       time:   [318.26 ms 322.02 ms 325.68 ms]
       thrpt:  [30.705 Kelem/s 31.054 Kelem/s 31.420 Kelem/s]
change:
       time:   [-1.4820% +0.2780% +1.7946%] (p = 0.73 > 0.05)
       thrpt:  [-1.7630% -0.2772% +1.5043%]
1-conn/1-1b-resp/mtu-65536 (aka. HPS)/client: No change in performance detected.
       time:   [33.577 ms 33.742 ms 33.919 ms]
       thrpt:  [29.482  elem/s 29.636  elem/s 29.782  elem/s]
change:
       time:   [-0.5239% +0.1477% +0.8838%] (p = 0.67 > 0.05)
       thrpt:  [-0.8760% -0.1475% +0.5267%]

Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe

1-conn/1-100mb-resp/mtu-65536 (aka. Upload)/client: No change in performance detected.
       time:   [288.52 ms 358.94 ms 444.21 ms]
       thrpt:  [225.12 MiB/s 278.60 MiB/s 346.60 MiB/s]
change:
       time:   [-9.3333% +20.609% +56.422%] (p = 0.21 > 0.05)
       thrpt:  [-36.070% -17.087% +10.294%]

Found 11 outliers among 100 measurements (11.00%)
4 (4.00%) high mild
7 (7.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing MTU Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 1504 105.1 ± 19.4 89.9 150.3 1.00
neqo msquic reno on 1504 209.3 ± 12.3 200.4 238.8 1.00
neqo msquic reno 1504 214.0 ± 10.5 196.8 230.4 1.00
neqo msquic cubic on 1504 223.5 ± 16.7 195.9 250.9 1.00
neqo msquic cubic 1504 216.3 ± 17.3 196.8 250.9 1.00
msquic neqo reno on 1504 713.0 ± 19.2 676.4 736.7 1.00
msquic neqo reno 1504 721.4 ± 12.0 702.3 740.4 1.00
msquic neqo cubic on 1504 724.9 ± 14.7 706.4 753.2 1.00
msquic neqo cubic 1504 694.5 ± 12.9 670.2 713.2 1.00
neqo neqo reno on 1504 418.2 ± 10.0 406.8 436.6 1.00
neqo neqo reno 1504 423.5 ± 12.6 405.2 441.5 1.00
neqo neqo cubic on 1504 424.4 ± 18.5 401.0 457.9 1.00
neqo neqo cubic 1504 414.8 ± 12.4 400.6 437.1 1.00
msquic msquic 65536 107.4 ± 33.9 89.6 201.0 1.00
neqo msquic reno on 65536 219.2 ± 14.3 199.7 239.9 1.00
neqo msquic reno 65536 212.7 ± 13.4 197.9 236.6 1.00
neqo msquic cubic on 65536 213.5 ± 15.6 198.5 251.9 1.00
neqo msquic cubic 65536 205.7 ± 9.8 196.3 229.9 1.00
msquic neqo reno on 65536 89.2 ± 9.5 81.4 113.3 1.00
msquic neqo reno 65536 95.6 ± 18.7 81.4 156.7 1.00
msquic neqo cubic on 65536 89.4 ± 10.5 82.4 116.6 1.00
msquic neqo cubic 65536 99.9 ± 22.5 81.3 174.4 1.00
neqo neqo reno on 65536 136.7 ± 22.5 118.8 204.4 1.00
neqo neqo reno 65536 152.3 ± 48.3 116.3 323.1 1.00
neqo neqo cubic on 65536 205.8 ± 116.8 124.6 443.1 1.00
neqo neqo cubic 65536 145.7 ± 19.7 120.7 190.2 1.00

⬇️ Download logs

@larseggert larseggert merged commit b61136f into main Nov 4, 2024
60 of 67 checks passed
@larseggert larseggert deleted the dependabot/docker/qns/lukemathwalker/cargo-chef-49338f8970645f531cbef198e3929910f1dbf17491d73289ab838d5ac7ae3511 branch November 4, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant