feat: Replace HashMap with EnumMap
#2434
Open
+448
−379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In several places.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2434 +/- ##
==========================================
- Coverage 95.28% 95.27% -0.02%
==========================================
Files 114 114
Lines 37111 37124 +13
Branches 37111 37124 +13
==========================================
+ Hits 35363 35370 +7
- Misses 1742 1748 +6
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to cb058cb. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 9734cf2. decode 4096 bytes, mask ff: No change in performance detected. time: [10.883 µs 10.928 µs 10.979 µs]
change: [-0.0790% +0.3972% +0.8805%] (p = 0.12 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.1278 ms 3.1370 ms 3.1477 ms]
change: [-0.3435% +0.0774% +0.5065%] (p = 0.72 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [17.670 µs 17.727 µs 17.785 µs]
change: [-0.2851% +0.0766% +0.4274%] (p = 0.69 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.4025 ms 5.4142 ms 5.4273 ms]
change: [-0.3636% -0.0378% +0.2910%] (p = 0.82 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [6.6542 µs 6.6786 µs 6.7054 µs]
change: [-0.5278% +0.1345% +0.8746%] (p = 0.70 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.7580 ms 1.7581 ms 1.7583 ms]
change: [-0.0130% -0.0026% +0.0073%] (p = 0.62 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [91.006 ns 91.301 ns 91.604 ns]
change: [-0.6340% -0.1124% +0.3670%] (p = 0.67 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [109.42 ns 109.71 ns 110.03 ns]
change: [-0.3850% +0.0241% +0.4713%] (p = 0.91 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [108.94 ns 109.28 ns 109.72 ns]
change: [-0.5127% -0.0140% +0.4881%] (p = 0.96 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [93.509 ns 93.663 ns 93.824 ns]
change: [-1.0293% -0.0611% +0.8517%] (p = 0.90 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.45 ms 111.51 ms 111.57 ms]
change: [-0.0648% +0.0051% +0.0752%] (p = 0.89 > 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.2739 µs 5.4841 µs 5.7227 µs]
change: [-1.8321% +1.0953% +4.2502%] (p = 0.49 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [37.114 ms 37.193 ms 37.281 ms]
change: [+0.7097% +0.9949% +1.2954%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [37.020 ms 37.098 ms 37.187 ms]
change: [+1.3268% +1.6221% +1.9456%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [36.841 ms 36.898 ms 36.955 ms]
change: [+0.8428% +1.0837% +1.3225%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [37.439 ms 37.501 ms 37.562 ms]
change: [+2.4179% +2.6554% +2.8913%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: Change within noise threshold. time: [833.85 ms 844.05 ms 854.64 ms]
thrpt: [117.01 MiB/s 118.48 MiB/s 119.93 MiB/s]
change:
time: [-3.7879% -2.1275% -0.6143%] (p = 0.01 < 0.05)
thrpt: [+0.6181% +2.1737% +3.9370%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [315.84 ms 319.26 ms 322.69 ms]
thrpt: [30.989 Kelem/s 31.322 Kelem/s 31.662 Kelem/s]
change:
time: [-1.8003% -0.2271% +1.3499%] (p = 0.78 > 0.05)
thrpt: [-1.3319% +0.2276% +1.8333%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [25.423 ms 25.574 ms 25.723 ms]
thrpt: [38.876 elem/s 39.102 elem/s 39.334 elem/s]
change:
time: [-0.9017% -0.0401% +0.8596%] (p = 0.92 > 0.05)
thrpt: [-0.8523% +0.0401% +0.9099%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. time: [1.8316 s 1.8519 s 1.8725 s]
thrpt: [53.405 MiB/s 54.000 MiB/s 54.596 MiB/s]
change:
time: [-4.9163% -3.5835% -2.1294%] (p = 0.00 < 0.05)
thrpt: [+2.1758% +3.7167% +5.1705%]
Client/server transfer resultsPerformance differences relative to 9734cf2. Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.
|
mxinden
approved these changes
Feb 10, 2025
| pub const MAX_DATAGRAM_FRAME_SIZE: TransportParameterId = 0x0020; | ||
| #[allow(clippy::enum_clike_unportable_variant)] | ||
| #[derive(Debug, Clone, Enum, PartialEq, Eq)] | ||
| pub enum TransportParameterId { |
There was a problem hiding this comment.
Very much in favor of this enum!
martinthomson
approved these changes
Feb 10, 2025
Co-authored-by: Martin Thomson <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several places.