Skip to content
This repository has been archived by the owner on Nov 11, 2019. It is now read-only.

Commit

Permalink
please_cli: pass USE_NIX to please
Browse files Browse the repository at this point in the history
In order to generate the base image we need to manually edit the
`please` file and toggle the `USE_NIX` variable. This patch will
simplify the process.
  • Loading branch information
Rail Aliiev committed Nov 21, 2018
1 parent ae0004b commit 30b0a8e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion please
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ NC='\033[0m'


USE_DOCKER=1
USE_NIX=0
USE_NIX=${USE_NIX:-0}
if [ -f /.dockerenv ]; then
USE_NIX=1
. /etc/nix/profile.sh;
Expand Down
12 changes: 6 additions & 6 deletions src/docs/deploy/regular.rst
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ Once you verify that the project works on staging, you must check it off in
tracking Pull Request for this deployment, as shown bellow.

.. image:: step_4_verified_project_on_staging.png

The role of the release manager is that it ensures that all projects are
verified and tested before deploying to production.

Expand Down Expand Up @@ -113,7 +113,7 @@ Once you verify that the project works on production, you must check it off in
tracking Pull Request for this deployment, as shown bellow.

.. image:: step_7_verified_project_on_production.png

The role of the release manager is that it ensures that all projects are
verified and tested before deploying to production.

Expand Down Expand Up @@ -154,8 +154,8 @@ A good starting point for writing release notes is:
This step will take some time (~30-60min) also good Internet connection is
required.

.. warning:: This step currently doesn't work. Please ping @garbas to do this
instead of you (for now).
.. warning:: This step currently doesn't work on not NixOS platforms. Please
ping @garbas/@rail to do this instead of you (for now).

- First we need to create a temporary branch
- Then apply the tracking Pull Request of deployment to the temporary branch
Expand All @@ -168,12 +168,12 @@ required.
cd release-services
git checkout -b temp origin/staging
curl -L https://github.com/mozilla/release-services/pull/<PR_NUMBER>.patch | git am
./please -vv tools base-image \
USE_NIX=1 ./please -vv tools base-image \
--taskcluster-secret="repo:github.com/mozilla-releng/services:branch:production" \
--taskcluster-client-id="..." \
--taskcluster-access-token="..."
git branch -D temp
It might happen that push to docker hub will fail since the resulting docker
image is quite big (~1.5GB). When it fails you can only retrigger the
``docker push`` command.
Expand Down

0 comments on commit 30b0a8e

Please sign in to comment.