-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sccache v0.2.13 does not work when built with rustc 1.48 #887
Comments
Rust 1.48 was released a few days ago. This patch adds the fixes that will get flux passing in CI again. The following things needed addressed: - There is a new lint introduced that checks for `push_str` on a single char `str`, and recommends using `push` instead. - There is an open issue with `sccache` and rust 1.48. As a result, `sccache` is desabled for now. See mozilla/sccache#887
@SomeoneToIgnore going to look into that later tonight/early tomorrow. Could you check if the latest master works though? And see which unit tests fail? Looking into the release notes, there are some potential cli flag changes that could cause the failure https://github.com/rust-lang/rust/releases/tag/1.48.0 |
It does work actually, thanks for the tip. So it's the release that we need. |
Unfortunately, yes - but I'd recommend to read #876 |
Rust 1.48 was released a few days ago. This patch adds the fixes that will get flux passing in CI again. The following things needed addressed: - There is a new lint introduced that checks for `push_str` on a single char `str`, and recommends using `push` instead. - There is an open issue with `sccache` and rust 1.48. As a result, `sccache` is desabled for now. See mozilla/sccache#887
In case people are interested this looks like a
(I assume OsString is a Until (unless?) Mozilla cut a new release there is a pre-built binary alongside each release (e.g. at https://github.com/mozilla/sccache/releases/tag/0.2.13) that works, or you can use |
See issue mozilla/sccache#887 for more details
Duplicate of #875 |
See issue mozilla/sccache#887 for more details
The same dummy "hello world" project + sccache does not work for rustc 1.48 but works for 1.47.
Here's a minimal example:
Create the script locally:
and then run it in Docker:
docker run --rm -v $(pwd)/test-sccache.sh:/test-sccache.sh rust:1.47 /test-sccache.sh
docker run --rm -v $(pwd)/test-sccache.sh:/test-sccache.sh rust:1.48 /test-sccache.sh
Expected: both runs work identically and finish successfully
Actual: 1.47 version works as expected, 1.48 version fails on the
RUSTC_WRAPPER="/usr/local/cargo/bin/sccache" cargo run
step:The text was updated successfully, but these errors were encountered: