Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1889195 - Fix empty dashboards caused by upcasing msgId #135

Closed
wants to merge 2 commits into from

Conversation

dmose
Copy link
Member

@dmose dmose commented Apr 2, 2024

@dmose dmose self-assigned this Apr 2, 2024
Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for fxms-skylight ready!

Name Link
🔨 Latest commit 5b24b03
🔍 Latest deploy log https://app.netlify.com/sites/fxms-skylight/deploys/66149bf47d07f200083e0d39
😎 Deploy Preview https://deploy-preview-135--fxms-skylight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 89 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@dmose dmose changed the title Fix empty dashboards caused by upcasing msgId Bug 1889195 - Fix empty dashboards caused by upcasing msgId Apr 2, 2024
@dmose dmose marked this pull request as ready for review April 2, 2024 23:27
@dmose
Copy link
Member Author

dmose commented Apr 2, 2024

I'm changing this to a full-on PR, ready for review. Either before that review, or as part of it, we need to do the Bugzilla / github / searchfox archeology mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1889195#c0 to be sure that we're not going to break anything here.

@dmose dmose marked this pull request as draft April 9, 2024 01:42
@dmose
Copy link
Member Author

dmose commented Apr 9, 2024

Move this back to draft - it fixes some dashboards while breaking others. Needs more investigation.

@dmose
Copy link
Member Author

dmose commented Apr 9, 2024

As an example, the dashboard for https://experimenter.services.mozilla.com/nimbus/np-survey-new-vs-existing-vs-returning-ru-zh-cn breaks.

I've figured out how to create a custom dimension of the lowercased message id, because I was hoping to do a case-insensitive compare on the Looker side. Unfortunately, such custom dimensions apparently can't be used as filters at the dashboard level itself.

One could imagine making the message-id field case-insensitive at the explore level, that probably requires more QA and discussions with Data folks, and might be the right way to go.

Perhaps there's another workaround, however.

@dmose
Copy link
Member Author

dmose commented Dec 11, 2024

I've just tested on main, and the dashboard mentioned in #135 (comment) has already been fixed. The other dashboards mentioned in the bug and currently not being shown will be reenabled by #432.

@dmose dmose closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant