Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bug 1906939 - Complete list of live messages #346

Closed
wants to merge 2 commits into from

Conversation

sarahhjchung
Copy link
Collaborator

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for fxms-skylight ready!

Name Link
🔨 Latest commit 82e6a78
🔍 Latest deploy log https://app.netlify.com/sites/fxms-skylight/deploys/66e890ca56f80e00076aa7f8
😎 Deploy Preview https://deploy-preview-346--fxms-skylight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 6 from production)
Accessibility: 97 (🟢 up 8 from production)
Best Practices: 92 (🟢 up 9 from production)
SEO: 89 (🟢 up 7 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarahhjchung
Copy link
Collaborator Author

sarahhjchung commented Sep 11, 2024

As part of this PR, we want to merge this Looker spike data (and eventually remote settings messages) into the tree after landing #370. When doing this, we will need to come up with some algorithm (similar to the script from this PR) to merge the data with our current list of live messages and de-duplicate it without losing important data.

Things to consider:

  • Currently, it makes the most sense to ensure that the data collected from the browser test are prioritized in the algorithm since we have preview URLs for them and not the Looker data.
  • Ensure that any broken preview URLs (for the Looker data) are not displayed.

@dmose
Copy link
Member

dmose commented Dec 4, 2024

@sarahhjchung Is there anything left to do here, or can we close this PR?

@sarahhjchung
Copy link
Collaborator Author

Nope, this can be closed!

@sarahhjchung sarahhjchung deleted the bug-1906939 branch December 4, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants