Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aws_gke_oidc_config and aws_gke_oidc_role modules #239

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

amitchell-moz
Copy link
Contributor

Add modules to provision AWS roles + OIDC configs to allow GKE workloads to assume AWS roles.

https://mozilla-hub.atlassian.net/browse/OPST-1509

This PR introduces 2 modules:

aws_gke_oidc_config
    creates an OIDC provider in AWS to setup a trust relationship between a cluster & AWS account
aws_gke_oidc_role
    creates AWS roles that use the trust relationship established by ^^ to allow GKE service accounts to assume AWS roles

These need to be separate modules because the OIDC provider URL must be unique per-account, but a given GKE cluster only has 1 OIDC endpoint. That means the OIDC provider tf must only be ran once, after that any number of roles can use it.

Changelog entry

add aws_gke_oidc_config and aws_gke_oidc_role modules

@amitchell-moz amitchell-moz changed the title add aws_gke_oidc_config and aws_gke_oidc_role modules feat: add aws_gke_oidc_config and aws_gke_oidc_role modules Dec 18, 2024
@github-actions github-actions bot added the minor This PR will increment a minor version label Dec 18, 2024
Copy link

Release plan

Directory Previous version New version
aws_gke_oidc_config 0.0.0 0.1.0
aws_gke_oidc_role 0.0.0 0.1.0

@amitchell-moz
Copy link
Contributor Author

amitchell-moz commented Dec 18, 2024

😿 I didn't realize my GHA bot commits weren't getting signed - the repo I tested on didn't require them. I'll need to get #240 merged, then recreate rebase this branch without the unsigned bot commits.

@amitchell-moz amitchell-moz merged commit a56bb2a into main Dec 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor This PR will increment a minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants