disable-lint #2024
disable-lint #2024
Conversation
| delete req.session.home; | ||
| return res.redirect(301, path.join("/", locale)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Revert this change please, git checkout master server/routes/auth/oauth2-callback.js
| var $allowWSToggle = $("#allow-lint-toggle"); | ||
| var toggle = !($allowWSToggle.hasClass("switch-enabled")); | ||
|
|
||
| if(toggle) { |
There was a problem hiding this comment.
Indenting issues here too. In Thimble we use 2-spaces. Your entire if block is indented 2-spaces too far.
| @@ -78,7 +78,24 @@ define(function(require) { | |||
|
|
|||
| return false; | |||
| }); | |||
| $("#allow-lint-toggle").click(function() { | |||
| // Toggle current value | |||
|
@sgupta7857 please reference the issue # this is fixing in the PR description. |
|
@humphd I made the changes on thimble side as you suggested. But the toggle button is not working for some reason. can you please guide what I am doing wrong here? |
|
this refers to the issue https://github.com/mozilla/thimble.mozilla.org/issues/1896 |
|
@sgupta7857 you removed all your changes to You'll also want to rebase your patch onto |
0.4 adding the toggle button for linting