pythongh-124043: Disallow mixing --with-trace-refs and `--disable-g…

…il` (python#124078) Tracing references is not currently thread-safe in the free-threaded build.
mpage · Sep 16, 2024 · 3b45df0 · 3b45df0
1 parent 44052b5
commit 3b45df0
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/Misc/NEWS.d/next/Build/2024-09-13-17-48-37.gh-issue-124043.Bruxpq.rst b/Misc/NEWS.d/next/Build/2024-09-13-17-48-37.gh-issue-124043.Bruxpq.rst
@@ -0,0 +1,2 @@
+Building using :option:`--with-trace-refs` is (temporarily) disallowed when the
+GIL is disabled.
diff --git a/configure b/configure
diff --git a/configure.ac b/configure.ac
@@ -1777,6 +1777,10 @@ then
             [Define if you want to enable tracing references for debugging purpose])
 fi
 
+if test "$disable_gil" = "yes" -a "$with_trace_refs" = "yes";
+then
+  AC_MSG_ERROR([--disable-gil cannot be used with --with-trace-refs])
+fi
 
 # Check for --enable-pystats
 AC_MSG_CHECKING([for --enable-pystats])
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Building using :option:`--with-trace-refs` is (temporarily) disallowed when the
		GIL is disabled.