Double timeout for Ansible test commands

[mpagot]

Double timeout for Ansible test commands in qesap regression
test_system. This is needed to avoid failure in zypper ref when LTSS
modules are enabled.

Summary by CodeRabbit

• Bug Fixes
  • Extended timeout for system deployment commands to ensure more reliable execution of complex setup processes.

[coderabbitai]

Walkthrough

The pull request introduces a modification to the timeout parameter in the qesap_ansible_cmd function call within a test system file. The timeout duration for system commands has been extended from 300 seconds to 600 seconds, allowing more time for the execution of remote commands related to environment setup in the SLES4SAP deployment test scenario.

Changes

File	Change Summary
tests/sles4sap/qesapdeployment/test_system.pm	Increased timeout for qesap_ansible_cmd from 300 to 600 seconds

Poem

🐰 Timeout stretched like a rabbit's ear,
Six hundred seconds, no more fear!
Commands now dance with extra time,
In SLES4SAP's testing paradigm
Patience wins the coding race 🕒

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

tests/sles4sap/qesapdeployment/test_system.pm (1)

31-31: LGTM! The timeout increase addresses the PR objective.

The change from 300s to 600s timeout will help prevent failures during zypper ref when LTSS modules are enabled.

Consider optimizing by applying different timeouts based on the command complexity:

-    qesap_ansible_cmd(cmd => $_, provider => $provider_setting, timeout => 600) for @remote_cmd;
+    my %cmd_timeouts = (
+        'zypper ref' => 600,    # Needs extended timeout for LTSS modules
+        'zypper lr' => 600,     # Package listing might be slow with many repos
+        'zypper in -f -y vim' => 600,        # Package installation needs more time
+        'zypper -n in ClusterTools2' => 600, # Package installation needs more time
+    );
+    for my $cmd (@remote_cmd) {
+        my $timeout = $cmd_timeouts{$cmd} // 300;  # Default to 300s for simple commands
+        qesap_ansible_cmd(cmd => $cmd, provider => $provider_setting, timeout => $timeout);
+    }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e0db044 and f472f76.

📒 Files selected for processing (1)

• tests/sles4sap/qesapdeployment/test_system.pm (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: CI: Running compile tests with perl v5.26
• GitHub Check: CI: Running unit tests with perl v5.32
• GitHub Check: CI: Running static tests with perl v5.32
• GitHub Check: CI: Running compile tests with perl v5.26
• GitHub Check: CI: Running unit tests with perl v5.32
• GitHub Check: CI: Running static tests with perl v5.32
• GitHub Check: CI: Running compile tests with perl v5.26