Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code simplifications #102

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Code simplifications #102

wants to merge 12 commits into from

Conversation

austinmroczek
Copy link
Contributor

Some recommended changes to streamline code.


def create_passhash(self, password):
"""
Create passhash from password
:param password: Password
:return:
"""
pwstring = HashPassword(password)
print(pwstring.hashed)
passhash = sha256(password.encode()).hexdigest()

Check failure

Code scanning / CodeQL

Use of a broken or weak cryptographic hashing algorithm on sensitive data High

Sensitive data (password)
is used in a hashing algorithm (SHA256) that is insecure for password hashing, since it is not a computationally expensive hash function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants