Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar mask transmission #190

Merged
merged 5 commits into from
Feb 20, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Bar mask transmission
Currently, the bar mask has a transmission of 0 at x=0. Presumably, the
intent was to set 0 transmission along the bar’s x-axis (at y=0). The
current implementation creates a vertical line that is perpendicular to
the wedge rather than through the wedge horizontally. This update
should fix that issue.
JarronL committed Feb 6, 2018
commit 2eea86eea788da42b52079a90d0faf44de39488c
2 changes: 1 addition & 1 deletion webbpsf/optics.py
Original file line number Diff line number Diff line change
@@ -826,7 +826,7 @@ def get_transmission(self, wave):
sigmar.clip(min=np.finfo(sigmar.dtype).tiny, max=2*np.pi, out=sigmar)
self.transmission = (1 - (np.sin(sigmar) / sigmar) ** 2)
# TODO pattern should be truncated past first sidelobe
self.transmission[x==0] = 0 # special case center point (value based on L'Hopital's rule)
self.transmission[y==0] = 0 # special case center point (value based on L'Hopital's rule)
# the bar should truncate at +- 10 arcsec:
woutside = np.where(np.abs(x) > 10)
self.transmission[woutside] = 1.0