Install FFT Configs (resolves Issue #102) #110
Merged
+29
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
ax3l
reviewed
Jul 18, 2017
| @@ -38,6 +38,7 @@ option(GEARSHIFFT_HCFFT "< Not implemented yet >" OFF) | |||
| set(GEARSHIFFT_NUMBER_WARM_RUNS "10" CACHE STRING "Number of repetitions of an FFT benchmark after a warmup.") | |||
| set(GEARSHIFFT_NUMBER_WARMUPS "2" CACHE STRING "Number of warmups of an FFT benchmark.") | |||
| set(GEARSHIFFT_ERROR_BOUND "0.00001" CACHE STRING "Error-bound for FFT benchmarks.") | |||
| set(GEARSHIFFT_INSTALL_CONFIG_PATH "/usr/share/gearshifft/" CACHE STRING "Default install path of config files.") | |||
There was a problem hiding this comment.
@tdd11235813 a better default would be ... "${CMAKE_INSTALL_PREFIX}/share/gearshifft/" CACHE ...
ax3l
reviewed
Jul 18, 2017
| Set `CMAKE_INSTALL_PREFIX` and `GEARSHIFFT_INSTALL_CONFIG_PATH` as you wish, otherwise defaults are used. | ||
| ``` | ||
| mkdir release && cd release | ||
| cmake -DCMAKE_INSTALL_PREFIX=/home/user/gearshifft |
There was a problem hiding this comment.
@tdd11235813 if you write $HOME/gearshifft and append a single \ and the end of the lines this even works with copy & paste
ax3l
reviewed
Jul 18, 2017
| ## Install | ||
|
|
||
| Set `CMAKE_INSTALL_PREFIX` and `GEARSHIFFT_INSTALL_CONFIG_PATH` as you wish, otherwise defaults are used. | ||
| ``` |
There was a problem hiding this comment.
add bash immediately after the three chars to add colorful highlighting :)
ax3l
reviewed
Jul 18, 2017
| @@ -61,7 +72,7 @@ Runs complete benchmark for clFFT (also applies for cuFFT, fftw, ..) | |||
| ``` | |||
| ./gearshifft_clfft | |||
| // equals | |||
There was a problem hiding this comment.
use # for bash comments (copy paste is nice)
ax3l
reviewed
Jul 18, 2017
| @@ -61,7 +72,7 @@ Runs complete benchmark for clFFT (also applies for cuFFT, fftw, ..) | |||
| ``` | |||
|
thank you so much for your comments, these will be integrated in the next commit :) |
tdd11235813
pushed a commit
to tdd11235813/gearshifft
that referenced
this pull request
Jul 19, 2017
- adds 2D C2C outplace and <float,double> 1D R2C inplace clFFT test - see ax3l's review of PR mpicbg-scicomp#110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEARSHIFFT_INSTALL_CONFIG_PATH.../share/gearshifft/Edit: see #102
Edit2: forgot to mention, that FFT configs moved:
config/toshare/gearshifft/