Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install FFT Configs (resolves Issue #102) #110

Merged
merged 2 commits into from
Jul 17, 2017

Conversation

tdd11235813
Copy link
Contributor

@tdd11235813 tdd11235813 commented Jul 17, 2017

  • installation path for the FFT configs is set via cmake GEARSHIFFT_INSTALL_CONFIG_PATH.
    • it is compiled into the binaries
    • if files have not been installed yet, gearshifft looks in ../share/gearshifft/
      • if there is no such directory gearshifft still uses its fallback extents

Edit: see #102
Edit2: forgot to mention, that FFT configs moved:

  • from config/ to share/gearshifft/

@tdd11235813 tdd11235813 mentioned this pull request Jul 17, 2017
@tdd11235813 tdd11235813 merged commit 1dced42 into mpicbg-scicomp:master Jul 17, 2017
@@ -38,6 +38,7 @@ option(GEARSHIFFT_HCFFT "< Not implemented yet >" OFF)
set(GEARSHIFFT_NUMBER_WARM_RUNS "10" CACHE STRING "Number of repetitions of an FFT benchmark after a warmup.")
set(GEARSHIFFT_NUMBER_WARMUPS "2" CACHE STRING "Number of warmups of an FFT benchmark.")
set(GEARSHIFFT_ERROR_BOUND "0.00001" CACHE STRING "Error-bound for FFT benchmarks.")
set(GEARSHIFFT_INSTALL_CONFIG_PATH "/usr/share/gearshifft/" CACHE STRING "Default install path of config files.")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdd11235813 a better default would be ... "${CMAKE_INSTALL_PREFIX}/share/gearshifft/" CACHE ...

Set `CMAKE_INSTALL_PREFIX` and `GEARSHIFFT_INSTALL_CONFIG_PATH` as you wish, otherwise defaults are used.
```
mkdir release && cd release
cmake -DCMAKE_INSTALL_PREFIX=/home/user/gearshifft
Copy link

@ax3l ax3l Jul 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdd11235813 if you write $HOME/gearshifft and append a single \ and the end of the lines this even works with copy & paste

## Install

Set `CMAKE_INSTALL_PREFIX` and `GEARSHIFFT_INSTALL_CONFIG_PATH` as you wish, otherwise defaults are used.
```
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add bash immediately after the three chars to add colorful highlighting :)

@@ -61,7 +72,7 @@ Runs complete benchmark for clFFT (also applies for cuFFT, fftw, ..)
```
./gearshifft_clfft
// equals
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use # for bash comments (copy paste is nice)

@@ -61,7 +72,7 @@ Runs complete benchmark for clFFT (also applies for cuFFT, fftw, ..)
```
Copy link

@ax3l ax3l Jul 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'```bash'

@tdd11235813
Copy link
Contributor Author

thank you so much for your comments, these will be integrated in the next commit :)

tdd11235813 pushed a commit to tdd11235813/gearshifft that referenced this pull request Jul 19, 2017
- adds 2D C2C outplace and <float,double> 1D R2C inplace clFFT test
- see ax3l's review of PR mpicbg-scicomp#110
@tdd11235813 tdd11235813 deleted the issue-102 branch September 11, 2018 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants