Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes uninitialized var, static libs, CLI options. #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tdd11235813
Copy link
Contributor

@tdd11235813 tdd11235813 commented Mar 15, 2019

  • cmake: GEARSHIFFT_BACKEND_FFTW_THREADS -> GEARSHIFFT_INTERNAL_FFTWX_THREADED
  • FFTWWrappers/MKL does not implement parameters for rigor & timelimit
    • so do not show CLI options for that
  • Fixes and moves non-MKL libs in MKL cmake variable.
  • show messages only when not set to quiet (FindFFTWWrappers.cmake)
  • Only restrict suffix for static libs (also in FindFFTW.cmake)

@emmenlau Can you test this PR on your systems? I changed some logic from your recent PRs.
edit: refers to #140

- cmake: GEARSHIFFT_BACKEND_FFTW_THREADS -> GEARSHIFFT_INTERNAL_FFTWX_THREADED
- FFTWWrappers/MKL does not implement parameters for rigor & timelimit
  - so do not show CLI options for that
- Fixes and moves non-MKL libs in MKL cmake variable.
- show messages only when not set to quiet.
- Only restrict suffix for static libs (also in FindFFTW.cmake)
@tdd11235813 tdd11235813 added FFTW FFTW back-end FFTWWrappers/MKL FFTWWrappers/MKL/Intel back-end labels Mar 15, 2019
@psteinb
Copy link
Contributor

psteinb commented Mar 21, 2019

works for me with xcode AppleClang 9.0.0.9000034, boost: stable 1.69.0 (bottled) and fftw: stable 3.3.8 (bottled). The latter 2 from homebrew. The more we support other OSes, the more we need to think about adding other OSes to our .travis build. Think about a multi-OS build matrix.

@psteinb
Copy link
Contributor

psteinb commented Jun 21, 2019

can this be merged?

@tdd11235813
Copy link
Contributor Author

tdd11235813 commented Jun 21, 2019

let me test this again. If it will work, then we can merge it.
Edit: going to rebase ...

@tdd11235813
Copy link
Contributor Author

tdd11235813 commented Jun 21, 2019

tested on taurus: if intel mkl and intel compiler versions do not match it seems this will then lead to a stupid segfault after program has finished and cleaned up. This is also present on previous versions.

Working module setup on taurus:

# in scs5 env
module load imkl/2019.1.144-iimpi-2019a Boost/1.70.0-iimpi-2019a icc/2019.1.144-GCC-8.2.0-2.31.1
CXX=icc cmake ..

with this modules it worked, but I could not test all cases (GNU MKL wrapper?). Can you also test again?

@psteinb
Copy link
Contributor

psteinb commented Jun 21, 2019 via email

@tdd11235813
Copy link
Contributor Author

k, np, I do not touch this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FFTW FFTW back-end FFTWWrappers/MKL FFTWWrappers/MKL/Intel back-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants