[Security] JwtAuthenticator add previous exception to thrown exceptio…

…n on failure
mpoiriert · Dec 12, 2023 · 35a5e39 · 35a5e39
1 parent 2125f6d
commit 35a5e39
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/packages/security/Http/Authenticator/JwtAuthenticator.php b/packages/security/Http/Authenticator/JwtAuthenticator.php
@@ -130,7 +130,11 @@ public function onAuthenticationSuccess(Request $request, TokenInterface $token,
 
     public function onAuthenticationFailure(Request $request, AuthenticationException $exception): ?Response
     {
-        throw new HttpException(Response::HTTP_FORBIDDEN, $this->translate($exception->getMessageKey(), $exception->getMessageData()));
+        throw new HttpException(
+            Response::HTTP_FORBIDDEN,
+            $this->translate($exception->getMessageKey(), $exception->getMessageData()),
+            previous: $exception
+        );
     }
 
     private function translate(string $message, array $data = []): string

diff --git a/packages/security/Tests/Http/Authenticator/JwtAuthenticatorTest.php b/packages/security/Tests/Http/Authenticator/JwtAuthenticatorTest.php
@@ -367,20 +367,27 @@ public function testOnAuthenticationFailure(): void
         $this->expectException(HttpException::class);
         $this->expectExceptionMessage($translatedMessage);
 
+        $previous = new CustomUserMessageAuthenticationException(
+            $message,
+            $messageData
+        );
+
         try {
             $this->object->onAuthenticationFailure(
                 new Request(),
-                new CustomUserMessageAuthenticationException(
-                    $message,
-                    $messageData
-                )
+                $previous
             );
         } catch (HttpException $error) {
             static::assertSame(
                 Response::HTTP_FORBIDDEN,
                 $error->getStatusCode()
             );
 
+            static::assertSame(
+                $previous,
+                $error->getPrevious()
+            );
+
             throw $error;
         }
     }
@@ -424,7 +431,7 @@ public function testOnAuthenticationFailureNoTranslator(): void
     }
 
     /**
-     * This is form the parent abstract class but we test it as part of a contract test.
+     * This is form the parent abstract class but, we test it as part of a contract test.
      *
      * @see AbstractAuthenticator
      */