Resolved code review feedback

mpoiriert · Apr 19, 2024 · 752312d · 752312d
1 parent d4e5e03
commit 752312d
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/packages/cron-job/Event/PreCronJobExecutionEvent.php b/packages/cron-job/Event/PreCronJobExecutionEvent.php
@@ -9,14 +9,13 @@
 
 class PreCronJobExecutionEvent extends Event
 {
-    private ?string $command;
+    private string $command;
 
     public function __construct(
         private CronJobExecution $execution,
         private bool $executionCancelled = false,
-        ?string $command = null
     ) {
-        $this->command = $command ?? $this->execution->getCronJob()?->getCommand();
+        $this->command = $this->execution->getCronJob()->getCommand();
     }
 
     public function getExecution(): CronJobExecution
@@ -36,12 +35,12 @@ public function setExecutionCancelled(bool $executionCancelled): self
         return $this;
     }
 
-    public function getCommand(): ?string
+    public function getCommand(): string
     {
         return $this->command;
     }
 
-    public function setCommand(?string $command): self
+    public function setCommand(string $command): self
     {
         $this->command = $command;