[TesterBundle] Remove ServiceTesterTrait fix #268

mpoiriert · May 21, 2024 · aa82471 · aa82471
1 parent 2d330bf
commit aa82471
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 76 deletions.
diff --git a/packages/tester-bundle/.phpstorm.meta.php b/packages/tester-bundle/.phpstorm.meta.php
diff --git a/packages/tester-bundle/DependencyInjection/ServiceTesterTrait.php b/packages/tester-bundle/DependencyInjection/ServiceTesterTrait.php
diff --git a/packages/tester-bundle/DrawTesterBundle.php b/packages/tester-bundle/DrawTesterBundle.php
@@ -12,14 +12,6 @@
 
 class DrawTesterBundle extends Bundle
 {
-    public static $ids = [];
-
-    public static function addServicesToTest($ids): void
-    {
-        $ids = (array) $ids;
-        self::$ids += $ids;
-    }
-
     public function build(ContainerBuilder $container): void
     {
         $container->addCompilerPass(new CompilerPass());

diff --git a/packages/tester-bundle/Tests/Messenger/TransportTesterTest.php b/packages/tester-bundle/Tests/Messenger/TransportTesterTest.php
@@ -14,13 +14,13 @@ class TransportTesterTest extends TestCase
 
     protected function setUp(): void
     {
-        $this->transportTester = $this->getService('messenger.transport.memory.draw.tester');
+        $this->transportTester = static::getContainer()->get('messenger.transport.memory.draw.tester');
     }
 
     public function testGetTransport(): void
     {
         static::assertSame(
-            $this->getService('messenger.transport.memory'),
+            static::getContainer()->get('messenger.transport.memory'),
             $this->transportTester->getTransport()
         );
     }

diff --git a/packages/tester-bundle/Tests/TestCase.php b/packages/tester-bundle/Tests/TestCase.php
@@ -2,7 +2,6 @@
 
 namespace Draw\Bundle\TesterBundle\Tests;
 
-use Draw\Bundle\TesterBundle\DependencyInjection\ServiceTesterTrait;
 use Draw\Bundle\TesterBundle\Http\BrowserFactoryInterface;
 use Draw\Bundle\TesterBundle\Http\HttpTesterTrait;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
@@ -11,7 +10,6 @@
 class TestCase extends KernelTestCase implements BrowserFactoryInterface
 {
     use HttpTesterTrait;
-    use ServiceTesterTrait;
 
     // For symfony 4.x
     protected static $class = AppKernel::class;

diff --git a/tests/Controller/Api/UsersControllerTest.php b/tests/Controller/Api/UsersControllerTest.php
@@ -7,18 +7,20 @@
 use Doctrine\ORM\EntityManagerInterface;
 use Draw\Bundle\UserBundle\Email\ForgotPasswordEmail;
 use Monolog\Level;
+use PHPUnit\Framework\Attributes\AfterClass;
+use PHPUnit\Framework\Attributes\BeforeClass;
 use Symfony\Component\HttpFoundation\Response;
 
 class UsersControllerTest extends TestCase
 {
-    /**
-     * @beforeClass
-     *
-     * @afterClass
-     */
+    #[
+        BeforeClass,
+        AfterClass,
+    ]
     public static function cleanUp(): void
     {
-        static::getService(EntityManagerInterface::class)
+        static::getContainer()
+            ->get(EntityManagerInterface::class)
             ->createQueryBuilder()
             ->delete(User::class, 'user')
             ->andWhere('user.email = :email')

diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -2,7 +2,6 @@
 
 namespace App\Tests;
 
-use Draw\Bundle\TesterBundle\DependencyInjection\ServiceTesterTrait;
 use Draw\Bundle\TesterBundle\Http\BrowserFactoryInterface;
 use Draw\Bundle\TesterBundle\Http\HttpTesterTrait;
 use Draw\Bundle\TesterBundle\Mailer\TemplatedMailerAssertionsTrait;
@@ -21,7 +20,6 @@ class TestCase extends KernelTestCase implements BrowserFactoryInterface
     }
     use MessengerTesterTrait;
     use MetricTesterTrait;
-    use ServiceTesterTrait;
     use TemplatedMailerAssertionsTrait;
 
     public function createBrowser(): AbstractBrowser