-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/export command documentation #212
Feature/export command documentation #212
Conversation
@olarno I have review the PR, here are some other notes: For phpcs and phpstan you can do:
If you run all the test the ConsoleIntegrationTest should fail once you more the command in the proper namespace. Just fix it. If you run the command in the test env it's normal that you don,t have the same list of command. Just focus on what the automation test output. |
…rguments. We also can export as txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to strong type all your parameters event if they are not object:
generateBlockText(string $title, int $width = 30, string $borderChar = '#', string $paddingChar = ' '): string
Phpstorm Hightligt this.
By experience there is no better IDE than PHPStorm for Php and there is a Symfony, doctrine and other plugin that help a lot.
You should really switch to Phpstorm and get use to it.
I applied your feedback, I struggle with the test 😓
|
a754ecf
into
mpoiriert:command_documentation
I have created a command to retrieve all available commands within the project. After obtaining the list of commands and their respective names, I have included three key elements for each command:
You can test this functionality by running the command using bin/console app:list-command. The resulting data can be found in the file tests/Command/result/defaultExport.json.
To begin testing, the objective is to:
Next step