Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac/option: fix type of global init variable #15395

Closed
wants to merge 1 commit into from

Commits on Nov 27, 2024

  1. mac/option: fix type of global init variable

    clipboard/clipboard.h includes common/global.h where the mpv_global
    struct is defined. clipboard/clipboard.h furthermore is now included on
    player/core.h, which is included in the swift bridging header. because
    of this swift now knows the mpv_global struct and isn't treating it as
    an OpaquePointer anymore. this leads to a build error because swift is
    strongly typed.
    
    properly type the global variable in the OptionHelper. also
    pre-emptively include the common/global.h file in the swift bridging
    header to prevent swift from 'forgetting' the mpv_global struct again,
    in the case the includes change.
    
    Fixes e1d30c4
    Akemi committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    45903ed View commit details
    Browse the repository at this point in the history