feat: add support for customHandleAcks in MQTT > 3 #1317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, need to add tests. This code is not working properly. Sorry for the noise. I'll update and will ping you once it's ready to review. |
|
hey @fmvilas any updates on this? |
|
Got super busy lately and can't find much time to code. Last time I remember I was getting into a rabbit hole with this PR. Implementation is not as easy as I expected. If someone could take it from here that would be awesome. |
|
If you wish to continue with this PR please remember to change destination branch from |
robertsLando
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1299