Add tests for inequality with relative times #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests demonstrate what seems to be an issue w/ relative DateTime and
gt
.gt
is overridden for DateTime - with relative timestamps,last
- the end of the range will beTime.now
, so comparing to it will fail.gteq
, which works, comes from a dynamic definition inBase
class and callsmap
:So perhaps the fix would be to get rid of
gt
override? But TBH, I don't have enough context for why it was introduced in 5810dcc and when it possibly became an issue.