Expand elem/notElem to allow fusion #559
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkkrp
approved these changes
May 19, 2024
|
Thanks! Strangely, I see this
and the merge button is grey. As far as I can see this is based directly on current master, so it is not clear how there could be "too many changes". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHC doesn't seem to inline or fuse the infix version of
elem/notElem. Fully expanding their uses does allow it.csv benchmarks get faster and
satisfy (\x -> x == '\'' || x == '\"') = oneOf ['\'', '\"']now holds with regards to performance. Note thatoneOf "'\""will still be slower, which is why I left the note unchanged.