Deploy Docker image to ghcr.io #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
force-pushed
the
docker-deploy
branch
2 times, most recently
from
2e3eb73 to
8a3f381
Compare
JersyJ
suggested changes
Jan 23, 2025
There was a problem hiding this comment.
I believe it does not make sense to run CI on the master branch if you are not evaluating test coverage for the branch or other specific metrics. Running linters is also unnecessary when they are already executed on every commit of a pull request.
In my opinion, deployments should be handled separately and triggered either by a push to the master branch or manually using workflow_dispatch
JersyJ
reviewed
Jan 23, 2025
|
I added a conclusion job, which is not super pretty, but often a requirement if one wants to get GitHub Actions to work well with both pull request and merge queue workflows.. Anyway, looks like it behaves like I wanted it to now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the deployment from a webhook to a docker push to the ghcr.io registry. It also switches to merge queues.