Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullhtml #1

Open
wants to merge 81 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
4da3d36
adding support for lists, headers, pre/code, and tables
petemichel77 Mar 29, 2016
15bfb3a
adding nested lists
petemichel77 Mar 29, 2016
37b4184
debugging
petemichel77 Mar 29, 2016
fa56c9f
debugging
petemichel77 Mar 29, 2016
8c5b8ff
Fix nested lists
petemichel77 Mar 29, 2016
9a7d1f4
handle images
petemichel77 Mar 29, 2016
d4d6c82
debugging
petemichel77 Mar 31, 2016
7673f71
remove debugging
petemichel77 Apr 26, 2016
c66c694
attempt to fix bullets
petemichel77 May 4, 2016
bcccb33
handle anchor tags with no href
petemichel77 Nov 7, 2016
95cd3e6
better null checking
petemichel77 Nov 7, 2016
03fac40
better handling for bolds and paragraphs for the new editor
petemichel77 Nov 27, 2017
e29caa4
better handling for bolds and paragraphs for the new editor
petemichel77 Nov 27, 2017
803a5e4
better handling for bolds and paragraphs for the new editor
petemichel77 Nov 27, 2017
fb794e6
handle pre spaces as well
petemichel77 Nov 27, 2017
e8748b8
debugging
petemichel77 Nov 28, 2017
44fce1e
debugging
petemichel77 Nov 28, 2017
81523b4
debugging
petemichel77 Nov 28, 2017
dc0ce69
debugging
petemichel77 Nov 28, 2017
7534c6c
add a newline after headers
petemichel77 Nov 28, 2017
5456a3f
handle newlines in bold/italics
petemichel77 Nov 28, 2017
b1db11a
handle newlines in bold/italics
petemichel77 Nov 28, 2017
0c36c03
handle newlines in bold/italics
petemichel77 Nov 28, 2017
328102f
handle newlines in bold/italics
petemichel77 Nov 28, 2017
d502e85
fix double bolding
petemichel77 Nov 28, 2017
31c6278
fix double bolding
petemichel77 Nov 28, 2017
c0bbf4e
fix links in table cells
petemichel77 Dec 19, 2017
30661a7
fix bug with multiple elements in b/strong/em/etc
petemichel77 Feb 15, 2018
9d65c56
add simple tester
petemichel77 Feb 15, 2018
b7feba3
added start param
austinparkk Feb 3, 2020
32cba67
add null check
austinparkk Feb 24, 2020
e7e85ee
Merge pull request #2 from guruhq/feature/ch24020/addNullCheckForLists
austinparkk Feb 24, 2020
c9e34ab
fix failing test case
maggie-lin Apr 27, 2020
14e0fc2
include setup details in readme
maggie-lin Apr 27, 2020
3eaf96b
ignore package-lock.json
maggie-lin Apr 27, 2020
8e4cdf5
fix bold text within h1 header
maggie-lin Apr 27, 2020
01c85b0
apply fix for bold text to h1, h2, h3
maggie-lin Apr 27, 2020
7f50e79
rename header function to specific it's for bold text
maggie-lin Apr 27, 2020
33b5c37
refactor check for header with bold text and include h4
maggie-lin Apr 28, 2020
6689a43
move changes to h1, h2, h3, h4 switch cases
maggie-lin Apr 28, 2020
1f91fcb
Merge branch 'bugfix/mlin/ch23417/fix-current-failing-tests' into ful…
maggie-lin Apr 28, 2020
0a63294
Merge branch 'fullhtml' of github.com:guruhq/slackify-html into bugfi…
maggie-lin Apr 28, 2020
3e4a28a
switch the check back inside of 'b' so whitespacing is maintained
maggie-lin Apr 28, 2020
f7bb03f
update the test case
maggie-lin Apr 28, 2020
bf87054
swap if statements order since the current order can lead to failures
maggie-lin Apr 29, 2020
2b2669e
Merge branch 'bugfix/mlin/ch23417/slack-formatting-wonky-when-user-cl…
maggie-lin Apr 29, 2020
3bf3f51
add new line to each line in pre code block
maggie-lin May 1, 2020
386fdab
add test for a code block with only text
maggie-lin May 1, 2020
99ab70f
Merge branch 'bugfix/mlin/ch20128/markdown-code-formatting-is-whacky-…
maggie-lin May 1, 2020
acaa519
add support for blockquote html tags
maggie-lin May 3, 2020
c381c91
include tests for links/files in blockquote
maggie-lin May 3, 2020
acba013
add new line to end of block quotes
maggie-lin May 4, 2020
0e3ccbf
add another new line since multiple block quotes can get turned into …
maggie-lin May 4, 2020
1469d5c
add second new line to test
maggie-lin May 4, 2020
df13c8b
add a couple more blockquote tests
maggie-lin May 6, 2020
45da5db
handle embedded new lines and line breaks in blockquote
maggie-lin May 11, 2020
0353a5b
add statement to else block
maggie-lin May 12, 2020
66eb055
Merge branch 'feature/mlin/ch28142/support-block-quotes-formatting-fo…
maggie-lin May 13, 2020
e2dbdbc
upgrade tap to fix 13 security vulnerabilties
maggie-lin May 14, 2020
3eb55eb
accomodate nodes inside table elements, add test case
juliankrispel Jul 8, 2022
8b98320
Merge pull request #8 from guruhq/remove-newlines-from-nested-content
juliankrispel Jul 8, 2022
6c5ff5a
first pass
EddyYeung1 Jan 2, 2023
f801368
test branch
EddyYeung1 Jan 3, 2023
bd930e6
remove m
EddyYeung1 Jan 3, 2023
50d5cd1
revert tests cleanup files
EddyYeung1 Jan 5, 2023
2951d4f
remove tap
EddyYeung1 Jan 9, 2023
a22a939
ignore ds store
EddyYeung1 Jan 23, 2023
e867e4c
Merge pull request #9 from guruhq/bug/eddyyeung/sc-93877/lists-not-re…
EddyYeung1 Jan 23, 2023
e498bf8
fix
EddyYeung1 Feb 3, 2023
958df4c
remove header conditional
EddyYeung1 Feb 6, 2023
e750863
Merge pull request #10 from guruhq/bug/eddyyeung/sc-100957/some-hyper…
EddyYeung1 Feb 6, 2023
2e36218
Remove unused tests
abevargas Apr 27, 2023
bcdb934
Update dependency & update package version to reflect tag
abevargas Apr 27, 2023
23d2407
Strip hidden tags in link <a> element text to avoid line breaks
abevargas Apr 27, 2023
6592194
Add tests with html that was previously failing due to hidden <br> ta…
abevargas Apr 27, 2023
273da6d
Cleanup
abevargas Apr 27, 2023
36e9f9e
Handle a case where there are potentially other tags surrounding text…
abevargas Apr 27, 2023
2ed6244
Merge pull request #12 from guruhq/sc-107234/fix_card_rendering_issue
abevargas Apr 27, 2023
ba6355f
update slackify to include collapsibles and add tests
juliankrispel Jan 12, 2024
87233c7
Merge pull request #13 from guruhq/sc-122502/add-collapsibles
juliankrispel Jan 16, 2024
148cd22
Merge pull request #14 from guruhq/master
juliankrispel Jan 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
Binary file not shown.
6 changes: 6 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,9 @@ build/Release
# Dependency directory
# https://www.npmjs.org/doc/misc/npm-faq.html#should-i-check-my-node_modules-folder-into-git
node_modules

# Package
package-lock.json

# logs
.DS_Store
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,8 @@ example usage:
var slackify = require('slackify-html');

var text = slackify('this <a href="http://github.com">link</a> is <b>important</b>');
// text variable contains 'this <http://github.com|link> is *important*'
// text variable contains 'this <http://github.com|link> is *important*'
```

### How to setup repo and test locally
https://app.getguru.com/card/TqGjya8c/slackifyhtml-basic-setup
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "slackify-html",
"version": "1.0.0",
"version": "1.3.4",
"description": "convert simple html to slack markdown",
"main": "slackify-html.js",
"scripts": {
"test": "tap tests.js"
"test": "jest test.js"
},
"repository": {
"type": "git",
Expand All @@ -25,10 +25,10 @@
},
"homepage": "https://github.com/mrq-cz/slackify-html",
"dependencies": {
"html-entities": "^1.1.3",
"html-entities": "^2.3.3",
"htmlparser": "^1.7.7"
},
"devDependencies": {
"tap": "^1.4.0"
"jest": "^29.3.1"
}
}
Loading