CI does not work locally

[edwinpjacques]

Expected behaviour

When I run "make lint", "make test" or "make ci" on a Linux host, I expect everything to work.

Actual behaviour

make lint dies on cpplint

libtool: link: ( cd "samples/.libs" && rm -f "libsamples.la" && ln -s "../libsamples.la" "libsamples.la" )
[root@ejacques-mbp-centos restclient-cpp]# make ci
cpplint --filter=-legal/copyright include/restclient-cpp/*.h source/*.cc
.
.
.
include/restclient-cpp/restclient.h:9:  #ifndef header guard has wrong style, please use: TF_DEV_ENV_CONTRAIL_THIRD_PARTY_RESTCLIENT_CPP_INCLUDE_RESTCLIENT_CPP_RESTCLIENT_H_  [build/header_guard] [5]
include/restclient-cpp/restclient.h:68:  #endif line should be "#endif  // TF_DEV_ENV_CONTRAIL_THIRD_PARTY_RESTCLIENT_CPP_INCLUDE_RESTCLIENT_CPP_RESTCLIENT_H_"  [build/header_guard] [5]
Done processing include/restclient-cpp/restclient.h
Done processing source/connection.cc
Done processing source/helpers.cc
Done processing source/restclient.cc
Total errors found: 6
make: *** [lint] Error 1

make test has three test failures, and one ignored test... it's unclear to the tester why.

[  FAILED  ] 3 tests, listed below:
[  FAILED  ] ConnectionTest.TestFollowRedirect
[  FAILED  ] ConnectionTest.TestFollowRedirectLimited
[  FAILED  ] ConnectionTest.TestGetInfoFromRedirect

 3 FAILED TESTS
  YOU HAVE 1 DISABLED TEST

make: *** [test] Error 1

I also get the same results above if I run the command make docker-services test.

make ci fails because of above errors.

Environment and debugging details

• gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-39)
• CentOS Linux 7
• 5.2
• git install from master
• libcurl version 7.29.0-57.el7_8.1 (vendor-provided)
• full error output above

[edwinpjacques]

Addressed this issue in PR #160

[edwinpjacques]

fix merged