-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write callback and termination API #160
Conversation
a326d80
to
518cc14
Compare
@mrtazz I am ready for your review, and hopefully your approval! I did a lot of work to get the CI working well again. I enabled all tests, even the OPTIONS test. I would very much appreciate if this can be approved, or if you can provide any necessary feedback for approval ASAP. Thank you. |
43b5b9e
to
f98b8de
Compare
I thought that my changing of the squid container was perhaps superfluous, as the old container works locally. However, it does not work in CI. I switched back to the container I provided and my custom configuration file, as that passed locally and in CI. |
@shawkinsl would you be able to provide any feedback on this merge request? It fixes CI and allows for stream processing of a GET response via write callback. |
Enables streaming get, and out-of-band termination of connection. Had to fix CI as well. Added necessary tests, and enabled a previously disabled test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
squashed commits, ready for approval.
@ElonDusk26 and @KaiPetzke would you mind to give a "thumbs up" on this review so I can get it merged with a clean conscience? Thanks! |
Astounding work @edwinpjacques! Hopefully @mrtazz agrees with me. |
Got out-of-band permission to merge from @mrtazz based on trust. Thanks for the kudos @ElonDusk26 ! I hope you can help fix the issue #158. It would be nice to have that resolved in the next release of code. Thank you. |
Sorry to disagree on this one. The callback declaration:
looks too much old-style C-ish to me. This is a C++ wrapper around libcurl, and we should use C++ APIs, not C APIs. The C++11 style would be to use The Pre-C++11-style would be to use a class with a virtual function |
Description
Checklist
Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.