-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for Mermaid diagrams in ADRs #45
Conversation
Create a codeblock with mermaid as the language tag and it'll render. See the new test ADR for an example.
This looks great! One comment on the versioning of the mermaid JS import. |
Ok, looks like the changes are rather large, so I'll have to set aside some time to look at it more closely at some point in the next week or so. |
No worries at all - any contributions are appreciated. After you've landed it, I'll kick up RC2 with this and the latest changes I've made, then if it all looks good I'll release 1.5.0 soon after that. |
I think this is ready to go now. GH is saying This branch cannot be rebased due to conflicts but upstream/master is fully merged into this branch… |
Yeah, this is rebase problems from my model refactoring. I've switched the project to allow merge commits temporarily, which GitHub is happy with (I can see the big green "Merge pull request" button), and will fold it in. Thank you for the change! |
Thank you! |
Create a codeblock with mermaid as the language tag and it'll render.
See the new test ADR for an example.