GLM exporter updates #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Each polygon needs to set the use_smooth bool so split normals can even be set - Validation needs to happen last, else uv lists or normal lists might have mismatching lengths - Made uv assignment code much more readable and understandable, should also be faster This is needed to also get rid of the stupid epsilons in the exporter. The broken normals assignment caused way to many exported vertices without using epsilons.
Removes some of the matrix math and should be overall faster.
Now using triangulated data directly. So, fixes mrwonko#40 Needs proper testing though. I don't have anything but the vanilla models to export and import, and that works just fine.
Broke it when I patched the transforms to happen before vertex evaluation on export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes importing split normals and some menu item unregister. Needs proper testing