Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sassc segmentation faults from breaking test builds #72

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

lucygilbert
Copy link
Contributor

There is a known issue with sassc (which Geneac inherits from sass-rails), ultimately drilling down to a Sprockets problem, which can cause segfaults which break builds. It has been described across numerous repos:

Looking back through closed PRs, this appears to be an ongoing issue for Geneac test builds. Forcing assets not to export concurrently is a suggested fix for this (the theory is that it's attempting to compile assets twice at the same time, which is causing a deadlock).

The only downside to this is slightly slower compilation because it doesn't do it in parallel, but Geneac would need substantially more assets than it currently has for that to become noticeable - and hopefully by the time Geneac has enough assets for this to be noticeable, newer versions of the gems will be out which will have solved the issue.

@lucygilbert
Copy link
Contributor Author

I'll rerun this a few times just to ensure it has fixed the problem

@lucygilbert lucygilbert force-pushed the bugfix/sassc_segfault_fix branch 8 times, most recently from 75b33e1 to 6537e30 Compare October 5, 2021 19:05
@lucygilbert
Copy link
Contributor Author

I've triggered the test build 10 times and all passed successfully - based on the incidence of segfault failures in the Actions tab, I'm pretty confident that this has fixed the error.

@mrysav
Copy link
Owner

mrysav commented Oct 7, 2021

My goodness - thank you so much!!! Honestly this was driving me crazy but not enough to look into it. I was looking at what it would take to move away from sassc entirely but this will stave off the migration for a bit longer!

We'll call it hacktoberfest-accepted!

@mrysav mrysav added bug Something isn't working hacktoberfest hacktoberfest-accepted counts towards your t-shirt! labels Oct 7, 2021
@mrysav mrysav merged commit d9a99cb into mrysav:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest hacktoberfest-accepted counts towards your t-shirt!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants