chore: PositionDataResponse clarity

msacco8 · Feb 6, 2024 · 5c4db22 · 5c4db22
1 parent 64099c8
commit 5c4db22
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/Forta-Bots-Challenge-4/liquidatable-positions/src/agent.ts b/Forta-Bots-Challenge-4/liquidatable-positions/src/agent.ts
@@ -56,10 +56,10 @@ export const provideHandleTransaction = (cometWithdrawSupplySignatures: string[]
               ? await positionFetcherUSDC.delegateCall(call, txEvent.from, txEvent.blockNumber)
               : call.address === positionFetcherWETH.cometAddress
                 ? await positionFetcherWETH.delegateCall(call, txEvent.from, txEvent.blockNumber)
-                : { newPosition: false, position: emptyPositionData };
+                : { newOrUpdatedPosition: false, position: emptyPositionData };
 
           // generate findings for new or updated positions
-          if (positionResponse.newPosition) {
+          if (positionResponse.newOrUpdatedPosition) {
             findings.push(createNewPositionFinding(baseAssetAddresses, positionResponse.position));
           }
         })

diff --git a/Forta-Bots-Challenge-4/liquidatable-positions/src/agent.utils.ts b/Forta-Bots-Challenge-4/liquidatable-positions/src/agent.utils.ts
@@ -22,7 +22,7 @@ export type PositionData = {
 };
 
 export type PositionDataResponse = {
-  newPosition: boolean;
+  newOrUpdatedPosition: boolean;
   position: PositionData;
 };
 
@@ -48,7 +48,7 @@ export const emptyPositionData: PositionData = {
 };
 
 export const emptyPositionDataResponse: PositionDataResponse = {
-  newPosition: false,
+  newOrUpdatedPosition: false,
   position: emptyPositionData,
 };
 

diff --git a/Forta-Bots-Challenge-4/liquidatable-positions/src/position.fetcher.ts b/Forta-Bots-Challenge-4/liquidatable-positions/src/position.fetcher.ts
@@ -108,7 +108,7 @@ export default class PositionFetcher {
         token: asset,
       };
       this.addToCache(borrower, position);
-      return { newPosition: true, position };
+      return { newOrUpdatedPosition: true, position };
     }
     return { ...emptyPositionDataResponse };
   }