feat: compound v3 liquidatable positions bot #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msacco8
changed the title
RCantu92
suggested changes
Feb 4, 2024
There was a problem hiding this comment.
Great work, Michael!
The major comments would be that the cache should be treated as a queue (as intended) rather than a stack. Also, that when we implement a class, such as your PositionFetcher, we also create a test suite for it. These two would be the reasons for my review to have Request changes.
Outside of that, the rest of the comments were more minor.
Forta-Bots-Challenge-4/liquidatable-positions/src/agent.spec.ts
Outdated
Show resolved
Hide resolved
Forta-Bots-Challenge-4/liquidatable-positions/src/agent.spec.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.