Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#581-refactor-too-long-function: improve function readability and decrease cognitive complexity #582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

higa-daniel
Copy link

Description

Improve function readability. Some nested conditional and repeated codes have been removed.

Type of change

Improvement.

How to test

Run unit tests without errors.

@higa-daniel higa-daniel changed the title #581-refactor-too-long-function: improve function readbility #581-refactor-too-long-function: improve function readability and decrease cognitive complexity Nov 19, 2024
@msiemens
Copy link
Owner

msiemens commented Dec 3, 2024

Hey @higa-daniel, it seems like you completely removed the update_multiple method, is that right? Also, to me the complexity of the update method is not too much of a concern, as it has detailed line comments that explain the different parts of the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants