Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM: dts: qcom: msm8909-fareastone-smart506: Add initial device tree #365

Conversation

bolilingmeng89006
Copy link

@bolilingmeng89006 bolilingmeng89006 commented Aug 10, 2024

Fareastone Smart 506 is a phone using the MSM8909 SoC released in 2015.

Add a device tree for with initial support for:

  • GPIO keys
  • GPIO LEDs
  • pm8909-vibrator
  • SDHCI (internal and external storage)
  • USB Device Mode
  • UART
  • WCNSS (WiFi/BT)
  • Regulators
  • LBC and BMS
  • Goodix GT9xx touchscreen
  • PWM panel backlight
  • Leedcon SL610W1D flash LED
  • Bosch BMA222 Accelerometer

@bolilingmeng89006 bolilingmeng89006 force-pushed the fareastone-smart506 branch 3 times, most recently from 7979208 to 67942f6 Compare August 10, 2024 10:19
Copy link
Member

@TravMurav TravMurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think all of this could be squashed into a single "initial" commit since there is no additions that won't be able to get in when msm8909 gets upstreamed. Could maybe keep lbc/bms separate since it's a separate commit in msm8909 bits for now.

Comment on lines 55 to 56
/* Actually leedcon,sl610w1d */
compatible = "sgmicro,sgm3140";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think upstream nowdays likes to ask questions i.e. "should it be a fallback compatible here?"

@TravMurav
Copy link
Member

Applied this in wip/msm8916/6.11-rc5, thanks!

@bolilingmeng89006 bolilingmeng89006 changed the base branch from wip/msm8916/6.10 to wip/msm8916/6.11 October 26, 2024 04:46
@bolilingmeng89006 bolilingmeng89006 deleted the fareastone-smart506 branch November 23, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants