Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add trace2d plot #108

Merged
merged 15 commits into from
Sep 29, 2017
Merged

Conversation

jeiros
Copy link
Contributor

@jeiros jeiros commented Sep 13, 2017

Proposed Feature / Bug-Fix

First proposal for the API of a 2D trace plot, as suggested in #105

One thing I have not been able to figure out is how to add 'lines' that connect the dots. For that, one would have to use pp.plot but that does not accept colour mapping to a series of values, which we need.

Example Figure

download

PR Check-list

  • Example added
  • Tests added
  • Docs added
  • Changelog updated

@msultan
Copy link
Collaborator

msultan commented Sep 14, 2017

This is such a cool plot to have have! +1 to @jeiros for getting this into MSMExplorer.

@jeiros
Copy link
Contributor Author

jeiros commented Sep 15, 2017

Thanks @msultan ! If you have any suggestions or improvements on the design of the function let me know!

Something that I've thought about adding is an argument to allow the user to pass a list of labels in case he's passing a list of arrays and wants to know which colour is mapping to what trajectory.

Because at the moment it just looks like this:

download

So can't know which trajectory is doing what.

@msultan
Copy link
Collaborator

msultan commented Sep 23, 2017

yea, the only way to do something more is to start implementing bokeh or plotly style interactive line plots that tell you the trajectory names as you hover over them. Otherwise, I think the best scenario right now is to write some helper functions that can find interesting trajectories though that is hard to define.

@cxhernandez cxhernandez merged commit d62694c into msmbuilder:master Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants