Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ffmpeg4.4 #15735

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Add ffmpeg4.4 #15735

merged 1 commit into from
Feb 23, 2023

Conversation

lazka
Copy link
Member

@lazka lazka commented Feb 17, 2023

The goal of this package is to provide ffmpeg 4.4.x and not conflict with ffmpeg 5.x etc.

Compared to the current 4.4 package this removes the frei0r-plugins dependency, since there is a dep cycle via frei0r-plugins -> opencv

edit:

# for packages switching to this:
depends=("${MINGW_PACKAGE_PREFIX}-ffmpeg4.4")
export PKG_CONFIG_PATH="${MINGW_PREFIX}/lib/ffmpeg4.4/pkgconfig:$PKG_CONFIG_PATH"

@wszqkzqk
Copy link
Contributor

May we make a list of the packages depend on ffmpeg4.4? Thus others can use ffmpeg5.

@lazka
Copy link
Member Author

lazka commented Feb 18, 2023

I was planning to follow #10725 (comment), but the 4.4 packages there take very long to build, so I'm going to test with vlc first. Not today though.

@wszqkzqk
Copy link
Contributor

I was planning to follow #10725 (comment), but the 4.4 packages there take very long to build, so I'm going to test with vlc first. Not today though.

Can we refer to archlinux?
ffmpeg4.4
ffmpeg5

The note of archlinux's vlc package

@wszqkzqk
Copy link
Contributor

I was planning to follow #10725 (comment), but the 4.4 packages there take very long to build, so I'm going to test with vlc first. Not today though.

Can we refer to archlinux? ffmpeg4.4 ffmpeg5

The note of archlinux's vlc package

Arch Linux's VLC denpend on ffmpeg4.4 duo to vaapi, which is unavailable in windows, so we may have a try.

@lazka
Copy link
Member Author

lazka commented Feb 19, 2023

I did a bit of cleanup in #15760 and synced that in here.

Arch Linux's VLC denpend on ffmpeg4.4 duo to vaapi, which is unavailable in windows, so we may have a try.

It is supported in theory, see https://packages.msys2.org/base/mingw-w64-libva and https://devblogs.microsoft.com/directx/video-acceleration-api-va-api-now-available-on-windows/, but we don't used it in ffmpeg, yeah. I'm just using VLC for now as a test to see if linking works and there are no cycles.

@lazka lazka force-pushed the ffmpg4.4 branch 2 times, most recently from 8669cd1 to ed00264 Compare February 21, 2023 04:25
@lazka
Copy link
Member Author

lazka commented Feb 21, 2023

pkgconf relocation is broken with the .pc files being in a subdirectory

@lazka lazka force-pushed the ffmpg4.4 branch 2 times, most recently from 459b703 to f3970ff Compare February 21, 2023 08:07
@lazka
Copy link
Member Author

lazka commented Feb 21, 2023

Yay.. It worked

@lazka lazka marked this pull request as ready for review February 22, 2023 18:28
@lazka lazka marked this pull request as draft February 22, 2023 19:05
The goal of this package is to provide ffmpeg 4.4.x and not conflict
with ffmpeg 5.x etc.

Compared to the current 4.4 package this removes the frei0r-plugins dependency,
since there is a dep cycle via frei0r-plugins -> opencv
@lazka lazka marked this pull request as ready for review February 23, 2023 18:02
@lazka lazka merged commit 50f1a83 into msys2:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants