-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mingw-w64: Update to 03d8a40f57 #22907
Conversation
438b3d7
to
6aec481
Compare
I strongly believe this update has caused a regression in the GDAL regression test suite. |
Could you provide any minimal sample code to reproduce the issue? |
just to confirm, looking at the build logs the only package versions differences are due to this mingw-w64 change, so seems likely. |
I figured the root cause. With git-12.0.0.r446.ga2d19218d-1, the below code prints 0x700, whereas with >= git-12.0.0.r458.g03d8a40f5-1, it prints 0x600. The GDAL code base has code paths that require test.c:
old working mingw64 install:
latest mingw64 install:
|
ok, so this seems to be related to commit mingw-w64/mingw-w64@90d3f33 |
…ssuming this is always available given how antiquated this is Workaround issue of msys2/MINGW-packages#22907 (comment)
Here is the discussion behind it: https://sourceforge.net/p/mingw-w64/mailman/mingw-w64-public/thread/20241018181538.bahgwxwolvx2n6cj%40pali/#msg58829839
That would break the mingw-w64 internal checks then, since we are not using msvcr70. We could revert that linked commit temporarily, but removing the checks for |
…ssuming this is always available given how antiquated this is Workaround issue of msys2/MINGW-packages#22907 (comment)
ok, I'll stick with that then since it doesn't seem to have obvious inconvenience (if one excepts the fact that current released versions of GDAL would be slightly broken when built against current mingw-w64, until our next release, but I guess that's life) thanks for your assistance |
There is some talk upstream to maybe move the default to I've also created boostorg/align#21 for boost to remove some old checks as well there. |
the repo seems abandoned, latest commit was created 2 years ago :( |
…ssuming this is always available given how antiquated this is Workaround issue of msys2/MINGW-packages#22907 (comment)
…ssuming this is always available given how antiquated this is Workaround issue of msys2/MINGW-packages#22907 (comment)
mingw-w64/mingw-w64@a2d1921...03d8a40
drop the revert since that should be fixed via mingw-w64/mingw-w64@c9eca28