Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux compat #7

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Linux compat #7

wants to merge 25 commits into from

Conversation

mmxe
Copy link

@mmxe mmxe commented Nov 21, 2016

Hi,
Can you review, test, and pull my linux-compat branch onto a new linux-compat branch in your repo?
I only have Fanuc machines so its only tested against FANUC, and the cmake files are FANUC specific as well.

ellisware and others added 25 commits March 4, 2016 18:06
Updated the project file for Visual Studio 2013
Introducing Basic Parameter, Diagnostic, and Macro Variable Read.
Importantly, the functions are tested, however, they are not complete to
handle every case of return type across byte, word and double word
values.
Updated so that program names are also displayed in the case for FS30i
and also updated cnc_statinfo() -> cnc_statinfo2()
errors:
string_buffer.cpp: In member function ‘void StringBuffer::timestamp()’:
string_buffer.cpp:116:64: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘__suseconds_t {aka long int}’ [-Wformat=]
   sprintf(mTimestamp + strlen(mTimestamp), ".%06dZ", tv.tv_usec);
                                                                ^
logger.cpp: In member function ‘const char* Logger::timestamp(char*)’:
logger.cpp:79:58: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘__suseconds_t {aka long int}’ [-Wformat=]
   sprintf(aBuffer + strlen(aBuffer), ".%06dZ", tv.tv_usec);
                                                          ^
…lisware.com/wordpress/mtconnect-fanuc-adapter-on-ubuntu-linux/

Fix compile warnings about improper format specifiers (%ld for long int instead of %d)

e.g.

fanuc_adapter.cpp: In member function ‘void FanucAdapter::configMacrosAndPMC(const char*)’:
fanuc_adapter.cpp:233:63: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘long int’ [-Wformat=]
    printf("Adding sample macro '%s' at location %d\n", name, v);
…rs from gLogger calls.

gLogger adds it's own newline, so log file was filling up with blank lines between log entries
…style command line switches and a short help message.
…start the adapter

This allows multiple adapters to run side by side on the same machine and each can write to their own log files.
remove unnecesary newline characters
@MZorzy
Copy link

MZorzy commented Nov 21, 2016

@mmxe may connect to focas/focas2's enabled controller?

@mmxe
Copy link
Author

mmxe commented Nov 21, 2016

Yes, I use it in my shop with FANUC 0i-MD and 0i-MF controllers (FOCAS2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants