Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changed? macro #7262

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Conversation

NoahTheDuke
Copy link
Collaborator

As discussed on slack.

Includes a wrapper around play-dynamic-ability.

@NoahTheDuke NoahTheDuke force-pushed the nb/more-wrappers-in-tests branch from 74f24ea to adfe89c Compare January 10, 2024 03:54
@NoahTheDuke NoahTheDuke force-pushed the nb/more-wrappers-in-tests branch from adfe89c to 3b81e55 Compare January 10, 2024 04:04
@butzopower
Copy link
Contributor

butzopower commented Jan 10, 2024

This looks great, testing it in the wild I think the expected is maybe reported incorrectly in test report.

I set it up to fail checking for change of +3 (when implementation is +2):

(is (changed? [(count (:hand (get-corp))) 3]
                  (click-prompt state :corp "Yes"))
        "Draw 1 (plus mandatory)")

and it gave me the following:

Draw 1 (plus mandatory)
(count (:hand (get-corp))) => (0 to 2)
Expected :-3
Actual   :2

@NoahTheDuke
Copy link
Collaborator Author

Ah crap, thanks for double checking that. I thought I had it right. 😭

@NoahTheDuke NoahTheDuke merged commit 621f3de into mtgred:master Jan 11, 2024
3 checks passed
@NoahTheDuke NoahTheDuke deleted the nb/more-wrappers-in-tests branch January 11, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants