Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose small wording change for Corp install message #7783

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

roitk
Copy link
Contributor

@roitk roitk commented Sep 30, 2024

Apologies if there was already a discussion about this. I searched through the issues but couldn't find one.

I wanted to propose a wording update for the log message printed when the Corp installs a non-ice card, given the changes to the official rules outlined in this blog post from a few years ago.

(Opening as draft while I figure out tests.)

@NoahTheDuke
Copy link
Collaborator

If you fix the tests, I can merge.

@roitk roitk marked this pull request as ready for review October 29, 2024 23:49
@roitk
Copy link
Contributor Author

roitk commented Oct 29, 2024

Oops, sorry about that! Got distracted and forgot I'd opened this. Hopefully tests should be fixed now

@NoahTheDuke NoahTheDuke merged commit b1deed4 into mtgred:master Nov 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants