Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant Dockerfile cleanup #68

Merged
merged 3 commits into from
Dec 6, 2020

Conversation

wcedmisten
Copy link

Running apt cleanup steps in a separate Docker layer doesn't make the image smaller, so I combined this with the apt-get install line.

See: waleedka/modern-deep-learning-docker#4

I also removed the autoremove and cleanup commands, because according to the official documentation, these are run after every install for official Ubuntu images (which this is based on).

Official Debian and Ubuntu images automatically run apt-get clean, so explicit invocation is not required.

@mtlynch
Copy link
Owner

mtlynch commented Dec 6, 2020

Wow, good tip. Thanks!

@mtlynch mtlynch merged commit d4dbaeb into mtlynch:master Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants