Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply if, got want pattern in more tests #654

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Apply if, got want pattern in more tests #654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions store/sqlite/entries_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func TestInsertDeleteSingleEntry(t *testing.T) {
}

if got, want := string(contents), input; got != want {
log.Fatalf("unexpected file contents: got %v, want %v", got, want)
log.Fatalf("contents=%s, want=%s", got, want)
}

meta, err := db.GetEntriesMetadata()
Expand All @@ -56,9 +56,8 @@ func TestInsertDeleteSingleEntry(t *testing.T) {
t.Fatalf("unexpected download count in entry metadata: got %v, want %v", meta[0].DownloadCount, 0)
}

expectedFilename := picoshare.Filename("dummy-file.txt")
if meta[0].Filename != expectedFilename {
t.Fatalf("unexpected filename: got %v, want %v", meta[0].Filename, expectedFilename)
if got, want := meta[0].Filename, picoshare.Filename("dummy-file.txt"); got != want {
t.Fatalf("filename=%s, want=%s", got, want)
}

err = db.DeleteEntry(picoshare.EntryID("dummy-id"))
Expand All @@ -71,8 +70,8 @@ func TestInsertDeleteSingleEntry(t *testing.T) {
t.Fatalf("failed to get entry metadata: %v", err)
}

if len(meta) != 0 {
t.Fatalf("unexpected metadata size: got %v, want %v", len(meta), 0)
if got, want := len(meta), 0; got != want {
t.Fatalf("metadata size=%d, want=%d", got, want)
}
}

Expand Down
Loading