Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bare list concatenation to allow non keyword options #112

Closed
wants to merge 1 commit into from
Closed

Use bare list concatenation to allow non keyword options #112

wants to merge 1 commit into from

Conversation

mtrudel
Copy link
Owner

@mtrudel mtrudel commented Feb 23, 2024

Fixup regression introduced in #111

@mtrudel
Copy link
Owner Author

mtrudel commented Feb 23, 2024

Note the failing test here - it seems like maybe :ssl uses a different heuristic to parse options than :gen_tcp does? But then why does server_test.exs:422 pass?

Feel free to poke around and figure out what's going on. I'll likely be able to spend some time on this tomorrow

@mtrudel mtrudel mentioned this pull request Feb 23, 2024
Merged
@danschultzer
Copy link
Contributor

danschultzer commented Feb 24, 2024 •
edited
Loading

I've made the list unique in #113.

@danschultzer danschultzer mentioned this pull request Feb 24, 2024
Merged
@mtrudel
Copy link
Owner Author

mtrudel commented Feb 24, 2024

Closed in favour of #113

@mtrudel mtrudel closed this Feb 24, 2024
@mtrudel mtrudel deleted the fixup_keyword_prefs branch February 24, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtrudel @danschultzer