Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings when building with clang-16 and gcc-12 #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix warnings when building with clang-16 and gcc-12 #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions include/clipp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1406,9 +1406,7 @@ class action_provider
//---------------------------------------------------------------
/** @brief executes all argument actions */
void execute_actions(const arg_string& arg) const {
int i = 0;
for(const auto& a : argActions_) {
++i;
a(arg.c_str());
}
}
Expand Down Expand Up @@ -4959,22 +4957,22 @@ class parser
//go through all exclusive groups of matching pattern
for(const auto& m : match.stack()) {
if(m.parent->exclusive()) {
for(auto i = int(missCand_.size())-1; i >= 0; --i) {
for(auto i = static_cast<int>(missCand_.size())-1; i >= 0; --i) {
bool removed = false;
for(const auto& c : missCand_[i].pos.stack()) {
for(const auto& c : missCand_[static_cast<std::size_t>(i)].pos.stack()) {
//sibling within same exclusive group => discard
if(c.parent == m.parent && c.cur != m.cur) {
missCand_.erase(missCand_.begin() + i);
missCand_.erase(missCand_.begin() + static_cast<decltype(missCand_)::difference_type>(i));
if(missCand_.empty()) return;
removed = true;
break;
}
}
//remove miss candidates only within current repeat cycle
if(i > 0 && removed) {
if(missCand_[i-1].startsRepeatGroup) break;
if(missCand_[static_cast<std::size_t>(i-1)].startsRepeatGroup) break;
} else {
if(missCand_[i].startsRepeatGroup) break;
if(missCand_[static_cast<std::size_t>(i)].startsRepeatGroup) break;
}
}
}
Expand Down Expand Up @@ -5103,8 +5101,8 @@ class parsing_result
*/
arg_mappings::size_type
unmapped_args_count() const noexcept {
return std::count_if(arg2param_.begin(), arg2param_.end(),
[](const arg_mapping& a){ return !a.param(); });
return static_cast<arg_mappings::size_type>(std::count_if(arg2param_.begin(), arg2param_.end(),
[](const arg_mapping& a){ return !a.param(); }));
}

/** @brief returns if any argument could only be matched by an
Expand Down Expand Up @@ -6239,7 +6237,7 @@ class usage_lines
os << buf.str();
if(i < group.size()-1) {
if(cur.line > 0) {
os << string(fmt_.line_spacing(), '\n');
os << string(static_cast<std::size_t>(fmt_.line_spacing()), '\n');
}
++cur.line;
os << '\n';
Expand Down Expand Up @@ -6319,7 +6317,7 @@ class usage_lines
else
lbl += fmt_.flag_separator();
}
lbl += flags[i];
lbl += flags[static_cast<std::size_t>(i)];
sep = true;
}
if(surrAlt) lbl += fmt_.alternative_flags_postfix();
Expand Down Expand Up @@ -6718,7 +6716,7 @@ class documentation
const int n = std::min(fmt.max_flags_per_param_in_doc(),
int(flags.size()));
for(int i = 1; i < n; ++i) {
lbl += fmt.flag_separator() + flags[i];
lbl += fmt.flag_separator() + flags[static_cast<std::size_t>(i)];
}
}
else if(!param.label().empty() || !fmt.empty_label().empty()) {
Expand Down Expand Up @@ -6872,7 +6870,7 @@ OStream&
operator << (OStream& os, const man_page& man)
{
bool first = true;
const auto secSpc = doc_string(man.section_row_spacing() + 1, '\n');
const auto secSpc = doc_string(static_cast<std::size_t>(man.section_row_spacing() + 1), '\n');
for(const auto& section : man) {
if(!section.content().empty()) {
if(first) first = false; else os << secSpc;
Expand Down Expand Up @@ -7003,7 +7001,7 @@ void print(OStream& os, const pattern& param, int level = 0)
template<class OStream>
void print(OStream& os, const group& g, int level)
{
auto indent = doc_string(4*level, ' ');
auto indent = doc_string(static_cast<std::size_t>(4*level), ' ');
os << indent;
if(g.blocking()) os << '~';
if(g.joinable()) os << 'J';
Expand Down