[Slider] Ensure onValueCommitted is called with the same value as latest onValueChange
#1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
component: slider
Netlify deploy preview |
mj12albert
changed the title
onValueCommitted is called with the same value as latest onValueChange
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
atomiks
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: https://codesandbox.io/p/sandbox/agitated-bose-mmg387
After: https://codesandbox.io/p/sandbox/gallant-thunder-mwkts8
Adapted @good-jinu's fix from mui/material-ui#44795 which ensures
onValueCommittedis called with the same value as the latestonValueChangeThe bug is easily reproducible by flicking the thumb along the track quickly on a touch device