Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy-ui][Accordion] First/Last style problems #40548

Open
remitoffoli opened this issue Jan 11, 2024 · 2 comments
Open

[joy-ui][Accordion] First/Last style problems #40548

remitoffoli opened this issue Jan 11, 2024 · 2 comments
Assignees
Labels
component: accordion This is the name of the generic UI component, not the React module! on hold There is a blocker, we need to wait package: joy-ui Specific to @mui/joy

Comments

@remitoffoli
Copy link

remitoffoli commented Jan 11, 2024

Steps to reproduce

Link to live example: https://codesandbox.io/p/sandbox/joyui-accordion-first-last-6k8zvz

Steps:

  1. Create an rounded AccordionGroup with Accordions inside
  2. Replace Accordions components with Custom components wrapping Accordions
  3. Or add conditions around the first or last accordion that return "false" or "null" if falsy

Current behavior

The first and last Accordion items are not set properly (data-first-child and data-last-child are not set).

While hovered, first's/last's backgrounds overlap with the border. And the last child is displaying an extra border.

image

Expected behavior

Same style as normal use.

Context

Using the latest version of JoyUI (5.0.0-beta.22)

Found this maybe-related issue: #40272

@remitoffoli remitoffoli added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 11, 2024
@remitoffoli remitoffoli changed the title [joy-ui][Accordion] [joy-ui][Accordion] First/Last style problems Jan 11, 2024
@zannager zannager added component: accordion This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Jan 12, 2024
@danilo-leal
Copy link
Contributor

Hey! 👋 Thanks for opening this issue; seeing some Joy UI love is awesome! Just passing by to share that the team might take a bit longer to get back on Joy UI-related issues due to the focus on the two major releases coming up for Material UI this year. Didn’t want to leave issues with the “waiting maintainer” status forever :) Definitely feel free to share any progress you’ve had on the issue, if any, though!

@danilo-leal danilo-leal removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 23, 2024
@siriwatknp siriwatknp added the on hold There is a blocker, we need to wait label Feb 20, 2024
@aacevski
Copy link
Contributor

Hey y'all - I opened a proposal pull request here:
#41457 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: accordion This is the name of the generic UI component, not the React module! on hold There is a blocker, we need to wait package: joy-ui Specific to @mui/joy
Projects
None yet
Development

No branches or pull requests

5 participants