Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy-ui][Accordion][AccordionGroup] Using css pseudo selectors for accordion group styles #41457

Closed
wants to merge 1 commit into from
Closed

[joy-ui][Accordion][AccordionGroup] Using css pseudo selectors for accordion group styles #41457

wants to merge 1 commit into from

Conversation

aacevski
Copy link
Contributor

Related issues: #40548

Using pseudo selectors seems to be fixing the issue here, I have opened one more PR for the ButtonGroup. If this implementation is fine, I will update the tests.

@mui-bot
Copy link

mui-bot commented Mar 11, 2024

Netlify deploy preview

https://deploy-preview-41457--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 5840dac

@danilo-leal danilo-leal added component: accordion This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Mar 11, 2024
@zannager zannager requested a review from siriwatknp March 12, 2024 12:49
@siriwatknp
Copy link
Member

siriwatknp commented Mar 14, 2024

I think we need to spend more time finding better solution than using data-* or :first-child for this problem. Currently, we are focusing on v6 which we will create next branch next week so I have to close this PR (the issue still remains so that we can track it).

Thank you so much for spending your time for the fix.

@siriwatknp siriwatknp closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: accordion This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants